PasswordMaker Forums

Firefox/SeaMonkey/Mozilla/Netscape/Flock Browser Extension => Feature Requests / Enhancements => Topic started by: Mauro on April 01, 2007, 03:32:09 AM

Title: Localization
Post by: Mauro on April 01, 2007, 03:32:09 AM
I would like to localize PasswordMaker to Brazilian Portuguese. However, PasswordMaker 1.6.1 doesn't support localization.

Is there a newer version which supports localization?

May I change version 1.6.1 to add support to localization?
Title: Localization
Post by: Eric H. Jung on April 06, 2007, 03:10:16 AM
Sorry, there isn't a newer version. You are welcome to localize PasswordMaker 1.6.1 and we'll post it for download.
Title: Localization
Post by: Mauro on April 08, 2007, 09:23:14 PM
Ok. I will work on localization of PasswordMaker 1.6.1. Thank you.
Title: Localization
Post by: Mauro on April 10, 2007, 04:44:42 PM
The file "basic-options.xul" (located in chrome/passwdmaker.jar/content/passwdmaker) has the following lines of code:

Code: [Select]
    <label value="This password was generated using the default account"/>
    <hbox>
      <label value="settings. Use the"/>
      <label style="margin-left: -1px; margin-right: -1px; color: blue; cursor: pointer"
        value="Advanced Options" onclick="onOptionsDialogButton('advanced');"/>
      <label id="lastVisibleElement" value="to change them."/>
    </hbox>

That code results in the following message:

(http://www.imagehosting.com/out.php/i453596_before.jpg)

The line break and the word order is good for English but may cause trouble for other languages.

In order to make it easy to translate that message, I suggest we change that code like this:

Code: [Select]
    <vbox>
      <label id="warningLbl" value="This password was generated using the default account settings."/>
      <label id="lastVisibleElement" value="Use the Advanced Options to change them." style="color: blue; cursor: pointer" onclick="onOptionsDialogButton('advanced');"/>
    </vbox>

Those lines would result in the following message:

(http://www.imagehosting.com/out.php/i453602_after.jpg)

What do you think?
Title: Localization
Post by: Miquel 'Fire' Burns on April 11, 2007, 02:41:31 PM
I guess that would work.
Title: Localization
Post by: Eric H. Jung on April 20, 2007, 02:43:51 PM
That's fine. Miquel, can you make the change in SourceForge?
Title: Localization
Post by: Miquel 'Fire' Burns on April 20, 2007, 03:31:49 PM
Done.
Title: Localization
Post by: Mauro on May 03, 2007, 11:23:28 PM
I'm still working on the localization of PasswordMaker but I guess you'd like to see the changes I made so far.

How can I send you a partially localized version of PasswordMaker?
Title: Localization
Post by: Miquel 'Fire' Burns on May 04, 2007, 01:44:22 AM
Maybe create a diff off the current trunk or something?
Title: Localization
Post by: Mauro on May 04, 2007, 03:37:16 AM
I prepared a new XPI file containing a partially localized version of PasswordMaker.

I tried to upload the XPI file but the following error ocurred:

"The requested file upload failed because suitable permissions have not been enabled on the 'uploads' directory. Please contact the board administrator and inform them of this error."
Title: Localization
Post by: Miquel 'Fire' Burns on May 04, 2007, 04:12:21 AM
Um, need to upload it someplace else. We disabled uploads here I believe, or if we are in fact allowing them again, we need to reconfigure some directories first.

Note, we will need the source anyway, so a diff would be nice.
Title: Localization
Post by: Mauro on May 04, 2007, 05:55:23 PM
I have uploaded the partially localized version of PasswordMaker to RapidShare (http://rapidshare.com/files/29471581/passwordmaker-1.6.1-localization.xpi.html).

That partially localized version of PasswordMaker contains English and Brazilian Portuguese only.

You have to change the locale settings in Firefox so that you can see the messages in Brazilian Portuguese. You may use the Quick Locale Switcher extension (https://addons.mozilla.org/en-US/firefox/addon/1333) to change the locale.

Please, note that I'm still working on it. So, I think it's not a good idea to put that code on SourceForge.

In order to see the differences between the localized version and the official version, you may use WinMerge (http://sourceforge.net/projects/winmerge).
Title: Localization
Post by: Eric H. Jung on May 06, 2007, 10:21:24 PM
Many thanks, Mauro! Post again when you have something we should start hosting on SourceForge for everyone to download.
Title: Re: Localization
Post by: m4j3s4 on June 03, 2007, 04:11:13 PM
Localization is finished.

I have uploaded the completely localized version of PasswordMaker to RapidShare (http://rapidshare.com/files/35017646/passwordmaker-1.6.2-localization.zip.html).

That localized version is based on version 1.6.2 as of 2007-jun-02 and it contains English and Brazilian Portuguese only.
Title: Re: Localization
Post by: Eric H. Jung on June 03, 2007, 05:07:24 PM
Wow! That's really impressive. That's a huge amount of work! Thank you so much! I've gotten lots of requests to submit PasswordMaker to BabelZilla (http://babelzilla.org) for translation to other languages, and now we can do it!

i kiss you!

Eric

edit: I will post again when this has been merged into the Subversion trunk and/or posted at BabelZilla
Title: Re: Localization
Post by: Eric H. Jung on June 21, 2007, 05:18:03 AM
I've committed Mauro's localization to Subversion here: https://passwordmaker.svn.sourceforge.net/svnroot/passwordmaker/ff+moz+ns+flock/tags/L10n. It can be viewed online here (http://passwordmaker.svn.sourceforge.net/viewvc/passwordmaker/ff%2Bmoz%2Bns%2Bflock/tags/L10n/). Now it has to be merged into the trunk. I'll post again when that's done.
Title: Re: Localization
Post by: Eric H. Jung on July 06, 2007, 03:04:10 AM
Hi Mauro,

I have a question. In updownload.js (your version: here (http://passwordmaker.svn.sourceforge.net/viewvc/passwordmaker/ff%2Bmoz%2Bns%2Bflock/tags/L10n/chrome/content/passwdmaker/updownload.js?revision=212&view=markup), 1.6.1 version: here (http://passwordmaker.svn.sourceforge.net/viewvc/passwordmaker/ff%2Bmoz%2Bns%2Bflock/trunk/chrome/content/passwdmaker/updownload.js?revision=11&view=markup)), you moved this code:

Code: [Select]
var unicodeConverter = Components.classes["@mozilla.org/intl/scriptableunicodeconverter"].createInstance(Components.interfaces.nsIScriptableUnicodeConverter);
  unicodeConverter.charset = "UTF-8";
  this.data = unicodeConverter.ConvertToUnicode(this.data) + unicodeConverter.Finish();

from the start() function to the onStreamComplete() function. Is this a mistake or a bug fix?

Thanks for your reply,
Eric
Title: Re: Localization
Post by: m4j3s4 on July 07, 2007, 02:27:42 AM
It's a bug fix.
I did so because I was getting messed up characters when downloading an uploaded configuration file which contains non-english caracters. For example, if a file contains "Padrão" (portuguese for "Default"), it turns to "Padrão".
Moving that code avoid the problem.
Title: Re: Localization
Post by: Eric H. Jung on July 07, 2007, 11:53:29 PM
OK, thanks. One more question. In basic-options.xul, Accounts is not translated (line 432 here (http://passwordmaker.svn.sourceforge.net/viewvc/passwordmaker/ff%2Bmoz%2Bns%2Bflock/tags/L10n/chrome/content/passwdmaker/basic-options.xul?revision=212&view=markup)). Is this a mistake?
edit:: I just realized this doesn't need to be translated since it's never displayed. Ignore that question.

I should have the merge completed today or tomorrow and will then submit to BabelZilla (http://babelzilla.org). Are you registered there? I'd like you to register as pt-br translator. Also, I'd like to credit you in About.xul. for your superb work! What name would you like to use? And do you want your name hyperlinked to a website or email address?

Thanks,
Eric
Title: Re: Localization
Post by: Eric H. Jung on July 08, 2007, 02:35:21 AM
Mauro,

Do you know why you modified install.js script from:
Code: [Select]
extLocaleNames: ['en-US'], // e.g. ['en-US', 'en-GB']
to:

Code: [Select]
extLocaleNames: null, // e.g. ['en-US', 'en-GB']
I thought it should be changed to:

Code: [Select]
extLocaleNames: ['en-US','pt-BR'], // e.g. ['en-US', 'en-GB']
No??

Also, after merging John Lenz's contribution into the trunk, the following new strings need to be translated:

Code: [Select]
advanced-options.xul:
(passwdmaker.dtd)
<!ENTITY advanced-options.101.label "Store Master Password Fingerprint for all accounts">
<!ENTITY advanced-options.101.tooltiptext "This is used to validate that future master passwords typed here match this master password.">
<!ENTITY advanced-options.102.label "Store Master Password Fingerprint for selected account">
<!ENTITY advanced-options.102.tooltiptext "This is used to validate that future master passwords typed here match this master password.">
<!ENTITY advanced-options.103.label "Master Password Fingerprint for selected account">
<!ENTITY advanced-options.104.label "Default Master Password Fingerprint">

passwordprompt.js:
(passwdmaker.properties)
passwordprompt.onOK.03=The master password is not correct.

passwordMakerOverlay.js:
(passwdmaker.properties)
passwdmakerOverlay.generatepassword.03=Master Password matches stored fingerprint
passwdmakerOverlay.generatepassword.04=Master Password doesn't match stored fingerprint
passwdmakerOverlay.generatepassword.05=Master Password fingerprint is not stored on disk

Thanks,
Eric
Title: Re: Localization
Post by: m4j3s4 on July 08, 2007, 07:42:55 PM
I based my work on version 1.6.2. That version contains this code:

Code: [Select]
textLocaleNames: null, // e.g. ['en-US', 'en-GB'].
I made no changes to that line because "install.js" is only required for Mozilla Suite, SeaMonkey and pre-release versions of Firefox. I tested the localization only on Firefox 2.0.

Today I've tested the new localized version on SeaMonkey and it doesn't work. Even with "extLocaleNames: ['en-US','pt-BR']". I'm going to debug it on SeaMonkey and make the corrections.

I will translate the new strings, as well.
Title: Re: Localization
Post by: Eric H. Jung on July 08, 2007, 08:25:17 PM
I will translate the new strings, as well.

Thank you. Maybe you could register at BabelZilla and translate them there instead of submitting a patch? It would be easier for me. I uploaded PasswordMaker 1.7b1 to BabelZilla yesterday.
Title: Re: Localization
Post by: m4j3s4 on July 09, 2007, 02:05:12 AM
I'm trying to translate the new strings at BabelZilla but I can't make the version 1.7b1 work on Firefox with pt-BR locale.
That's because BabelZilla doesn't support adding HTML tags inside entities in "passwdmaker.dtd" file and it messes up "tips.008.innerHTML" entity, which contains several HTML tags.

For instance, if an entity contains:
Code: [Select]
<br/>,then BabelZilla converts it to:
Code: [Select]
&lt;br/&gt;That results in the HTML tag being shown on PasswordMaker window instead of a line break.

I'm afraid we'll have to change "passwdmaker.dtd" file and remove the HTML tags from the entities.
Title: Re: Localization
Post by: Goofy on July 09, 2007, 08:35:26 AM
:) I confirm you cannot drop html tags inside a dtd file without much problems.

(sorry for double posting, this message also on BabelZilla)


 I know only a safe solution which is also a bit tedious. You should leave every html tag in the xul file and slalom around them with entities.
A simple example here :

Initial line 48 in tips.xul
Code: [Select]
<li>The order of the characters affects what is generated! Using <b>0123456789abcdef</b> creates different passwords<br/>than using <b>abcdef0123456789</b>"></li><br/>
Final line 48 in tips.xul
Code: [Select]
<li>&tip7.1;&nbsp;<b>0123456789abcdef</b>&nbsp;&tip7.2;<br/>&tip7.3;&nbsp;<b>abcdef0123456789</b>"></li><br/>(Note the addition of non-breaking spaces)

Corresponding entities in the related *.dtd
Code: [Select]
<!ENTITY tip7.1 "The order of the characters affects what is generated! Using">
<!ENTITY tip7.2 "creates different passwords">
<!ENTITY tip7.3 "than using"
Title: Re: Localization
Post by: m4j3s4 on July 09, 2007, 07:47:27 PM
I beg you pardon, but doing that can make difficult translating to some languages that don't use the same word order as English. Don't you think?

I would suggest removing the bold tags and anchor tags, which I think are not needed. As for the break-line tag, I think we can create one entity for each line.

What do you think?
Title: Re: Localization
Post by: Eric H. Jung on July 09, 2007, 08:12:16 PM
Mauro, do you what subversion commit access to contribute these changes?
Title: Re: Localization
Post by: Goofy on July 09, 2007, 08:15:28 PM
I beg you pardon, but doing that can make difficult translating to some languages that don't use the same word order as English. Don't you think?

I would suggest removing the bold tags and anchor tags, which I think are not needed. As for the break-line tag, I think we can create one entity for each line.

What do you think?


:) Have a look here
http://www.babelzilla.org/forum/index.php?s=&showtopic=3334&view=findpost&p=30904

I don't think it very difficult for translators to find tricks and get things in their language properly, in the case of these strings.
Title: Re: Localization
Post by: m4j3s4 on July 09, 2007, 08:25:04 PM
Eric, if you allow me access to subversion, I will make the changes.

However, I need you to decide what to do about the HTML tags: breaking up the strings, as Gooffy suggested, or remove the HTML tags.
Title: Re: Localization
Post by: Miquel 'Fire' Burns on July 09, 2007, 08:45:30 PM
Note, the way install.js is setup, the dtd and properties files should be in a passwdmaker subdirectory of the locale.
Title: Re: Localization
Post by: Eric H. Jung on July 09, 2007, 09:26:36 PM
Quote from: miquelfire
Note, the way install.js is setup, the dtd and properties files should be in a passwdmaker subdirectory of the locale.
I will fix install.rdf so it doesn't have the extra passwdmaker subdirectory (or you can do it if you like, it's a simple change and you have SVN commit privs).

Quote from: Mauro
Eric, if you allow me access to subversion, I will make the changes.
I need your userid on SourceForge. That is where Subversion is hosted for PasswordMaker.

Quote from: Mauro
I need you to decide what to do about the HTML tags
I think we should go with Goofy's suggestion, but I don't really care one way or the other. I like Goofy's suggestion more only because it allows us to use HTML markup in strings. With the solution you propose, we are a little more restricted in the future. I will leave it to you to decide, Mauro.
Title: Re: Localization
Post by: Miquel 'Fire' Burns on July 09, 2007, 09:57:10 PM
There, I fixed it. Don't know what I was doing reading that part of the code in the first place.
Title: Re: Localization
Post by: m4j3s4 on July 10, 2007, 12:25:30 AM
Quote
I need your userid on SourceForge. That is where Subversion is hosted for PasswordMaker.
My userid on SourceForge is 1840283 and my username is sjoruam.

Quote
I think we should go with Goofy's suggestion, but I don't really care one way or the other. I like Goofy's suggestion more only because it allows us to use HTML markup in strings. With the solution you propose, we are a little more restricted in the future. I will leave it to you to decide, Mauro.
I have another solution. Instead of changing the DTD file, how about we change "tips.xul" file so that it converts the HTML tags properly?

This is the original code:
Code: [Select]
<script type="application/x-javascript" src="chrome://passwdmaker/content/utils.js"/>

<xul:hbox style="margin: 1em;">
<p>
&tips.001.innerHTML;
<br/><br/>
<ul>
<li>&tips.002.innerHTML;</li><br/>
<li>&tips.003.innerHTML;</li><br/>
<li>&tips.004.innerHTML;</li><br/>
<li>&tips.005.innerHTML;</li><br/>
<li>&tips.006.innerHTML;</li><br/>
<li>&tips.007.innerHTML;</li><br/>
<li>&tips.008.innerHTML;</li>
</ul>
</p>
</xul:hbox>

We can change it like this:
Code: [Select]
<script type="application/x-javascript" src="chrome://passwdmaker/content/tips.js"/>

<xul:hbox style="margin: 1em;">
<p>
<span id="001">&tips.001.innerHTML;</span>
<br/><br/>
<ul>
<li id="002">&tips.002.innerHTML;</li><br/>
<li id="003">&tips.003.innerHTML;</li><br/>
<li id="004">&tips.004.innerHTML;</li><br/>
<li id="005">&tips.005.innerHTML;</li><br/>
<li id="006">&tips.006.innerHTML;</li><br/>
<li id="007">&tips.007.innerHTML;</li><br/>
<li id="008">&tips.008.innerHTML;</li>
</ul>
</p>
<script language="javascript">
document.getElementById("001").innerHTML = decodeHTML(document.getElementById("001").innerHTML);
document.getElementById("002").innerHTML = decodeHTML(document.getElementById("002").innerHTML);
document.getElementById("003").innerHTML = decodeHTML(document.getElementById("003").innerHTML);
document.getElementById("004").innerHTML = decodeHTML(document.getElementById("004").innerHTML);
document.getElementById("005").innerHTML = decodeHTML(document.getElementById("005").innerHTML);
document.getElementById("006").innerHTML = decodeHTML(document.getElementById("006").innerHTML);
document.getElementById("007").innerHTML = decodeHTML(document.getElementById("007").innerHTML);
document.getElementById("008").innerHTML = decodeHTML(document.getElementById("008").innerHTML);
</script>

Also, we have to create "tips.js" like this:
Code: [Select]
function decodeHTML(html) {
return html.replace(/&lt;/g, "<").replace(/&gt;/g, ">");
}

I tested this solution on Firefox and it works fine.

What do you think?
Title: Re: Localization
Post by: m4j3s4 on July 10, 2007, 12:33:53 AM
There's another problem.

The entity tips.008.innerHTML contains an ampersand as one the examples of non-alphanumeric characters and symbols.
I suggest removing it because it is causing trouble when loading "tips.xul".

Title: Re: Localization
Post by: Eric H. Jung on July 10, 2007, 02:12:01 AM
Mauro--you have SVN access now. If you want to change this implementation to your idea or Goofy's or something else, please go ahead.

Here is what I committed to SVN. Please let me know if you think this is OK. This idea is different from both Goofy's and Mauro's. tips.xul is now a thin container for chrome://passwdmaker/locale/character-tips.html. Each locale creates their own locale/**-**/character-tips.html. This is the most flexible and easiest for translators, I think... no?

Code: [Select]
<!-- tips.xul -->
<?xml-stylesheet href="chrome://global/skin/global.css" type="text/css"?>
<!DOCTYPE window SYSTEM "chrome://passwdmaker/locale/passwdmaker.dtd">

<dialog
    id="passwordmakeraccountsettings"
    windowtype="passwordmaker"
    title="&tips.window.title;"
    orient="vertical"
    xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
    persist="screenX screenY width height">

  <iframe src="chrome://passwdmaker/locale/character-tips.html" flex="1" style="border: 1px black solid"/>
 
</dialog>

Code: [Select]
<!-- chrome://passwdmaker/locale/character-tips.html -->

<style>
  * {
    font-size: x-small;
    font-family: verdana, sans-serif;
  }
  li {
    margin-bottom: 1em;
  } 
  a {
    color: blue;
    cursor: pointer
  }
</style>
<p>
The characters field contains the list of characters used in generating this password.
Here are some tips to follow when selecting characters:
</p>
<ul>
<li>If you require passwords compatible with PasswordMaker 0.6 and before, you must use
0123456789abcdef. If your passwords are missing leading zeros which existed in 0.6,
try using the hash algorithm MD5 Version 0.6 or HMAC-MD5 Version 0.6.</li>
<li>A minimum of two characters is required</li>
<li>Characters can be repeated</li>
<li>Using the same character more than once causes that character to appear more often in the generated password</li>
<li>The more unique characters that are specified, the greater the variety of characters in the generated password</li>
<li>The order of the characters affects what is generated! Using 0123456789abcdef creates different passwords than using abcdef0123456789</li>
<li>You can specify non-English characters like those with
<a href="http://en.wikipedia.org/wiki/Diacritic">diacritical marks</a> (e.g., &#226;, &#229;, &#231;),
<a href="http://en.wikipedia.org/wiki/Diaeresis">diaeresis marks</a>,
(e.g., &#252;, &#228;, &#235;),
<a href="http://en.wikipedia.org/wiki/Ligature_%28typography%29">ligature marks</a>,(e.g., &#198;, &#0339;, &#223;),
non-alphanumeric characters and symbols (e.g., &#169; &#0174; &#8471; [email protected]#$%^&amp;*(){};), etc. If a character you desire does not appear on your keyboard,
don't fret. Most every Western character can be created bytyping ALT-, OPTION-, or CTRL-code key sequences. The key sequences vary by operating system.
For example, typing ALT+0222 in Windows (numbers must be typed on the numeric keypad) yields the Icelandic upper-case Thorn character: &#xfe;.
</li>
</ul>

The only problem is that BabelZilla WTS munges (http://en.wikipedia.org/wiki/Munge) HTML and XHTML files on download. I experienced this with my other extension on BabelZilla (FoxyProxy (http://foxyproxy.mozdev.org)). I don't really know how to fix this, but it doesn't make sense to me compromise PasswordMaker (or any other extension) for the technical restrictions of BabelZilla.

I am open other suggestions, and welcome changes.

Thank you,
Eric
Title: Re: Localization
Post by: Goofy on July 10, 2007, 08:09:33 AM
:) My opinion here (http://www.babelzilla.org/forum/index.php?s=&showtopic=3334&view=findpost&p=30927)
Title: Re: Localization
Post by: Eric H. Jung on July 10, 2007, 04:09:16 PM
Here is what I committed to SVN. Please let me know if you think this is OK. This idea is different from both Goofy's and Mauro's. tips.xul is now a thin container for chrome://passwdmaker/locale/character-tips.html. Each locale creates their own locale/**-**/character-tips.html.

This idea has been discarded in favor of Teo's idea here (http://www.babelzilla.org/forum/index.php?s=&showtopic=3334&view=findpost&p=30925). I will commit the code to SVN sometime tonight.
Title: Re: Localization
Post by: m4j3s4 on July 10, 2007, 07:33:33 PM
Eric, thank you for allow me access do SVN.

As you've chosen Teo's idea and you will commit the new code, I will make no changes to "tips.xul" anymore.

However, the new localized version is not working on Seamonkey. So, I have to debug it on Seamonkey and probably there will a bug fix.
Title: Re: Localization
Post by: Eric H. Jung on July 10, 2007, 08:18:38 PM
If you'd like to commit Teo's idea to SVN, please go ahead.
Title: Re: Localization
Post by: m4j3s4 on July 10, 2007, 08:42:28 PM
Ok. So I will commit Teo's idea to SVN after testing in on Firefox.

However, I'm afraid I will not be able to do it today. Maybe tomorrow.
Title: Re: Localization
Post by: Eric H. Jung on July 10, 2007, 09:06:08 PM
Ok. So I will commit Teo's idea to SVN after testing in on Firefox.

However, I'm afraid I will not be able to do it today. Maybe tomorrow.


That is OK. I will submit it back to BabelZilla when you are finished. Thank you!!
Title: Re: Localization
Post by: m4j3s4 on July 11, 2007, 04:16:58 AM
I made the changes to pt-BR locale according to Teo's suggestion and commited them to SVN.

However, there're some issues:

1. Clicking on the "Tips" button for the first time with a clean profile, results in a window too small.
(http://www.imagehosting.com/out.php/i889498_tela1.jpg)

    I may debug it to find out how to prevent that.

2. After resizing the window, if we click on a link, it opens the Wikipedia's page inside the iframe, replacing the previous text.
(http://www.imagehosting.com/out.php/i889537_tela3.jpg)

    IMHO, those links are not needed because the text already lists examples of diacritical marks, diaeresis marks and ligature marks.

3. IMHO, the white background doesn't look good on a dialog window.
Title: Re: Localization
Post by: Teo on July 11, 2007, 11:57:07 AM
Mauro,
I tested mine changes on new blank profile on Fx 2.0.0.4 EN and PL version with extension downloaded from BabelZilla and all working properly. Links are opens in new tabs in the browser. See how tips window looks in the English and Polish window.
(http://fsc.com.pl/heli/pm1.png)
(http://fsc.com.pl/heli/pm2.png)
Title: Re: Localization
Post by: m4j3s4 on July 11, 2007, 12:56:07 PM
Ok. You're right, Teo. I made a mistake. I will correct that.

Thank you for replying.

I have a question. Your changes removed the bolds that existed in the original window, as below.
(http://www.imagehosting.com/out.php/i891046_tela4.jpg)

How can we recover that?
Title: Re: Localization
Post by: teo951 on July 11, 2007, 01:33:16 PM
Straight way by XUL is impossible. We can use the same method as for links, but in this case we have to write some entity more and add style. Bold characters will be in the Fx 3.0 :)
Title: Re: Localization
Post by: m4j3s4 on July 11, 2007, 03:02:09 PM
Well, if Teo's solution drops the bolds, why don't we keep the original code and drop the bolds and the links?
After all, most of the dialog windows I've ever seen contains neither bolds or links.

What do you think?
Title: Re: Localization
Post by: Eric H. Jung on July 11, 2007, 03:44:31 PM
We can get rid of bolds. The links I'd like to keep, but if it's too much trouble, then get rid of them... especially the opening in the iframe problem. Ok, get rid of links, too. By the way, the .link CSS class isn't necessary. There is a built-in class called "text-link".
Title: Re: Localization
Post by: Eric H. Jung on July 11, 2007, 03:58:20 PM
We should get rid of /locale/xx-XX/character-tips.html and go back to the old way since now there will be no markup in tips. This will keep XPI size smaller and prevent yet another file for translation (character-tips.html).
Title: Re: Localization
Post by: teo951 on July 11, 2007, 06:07:35 PM
Eric,
Please wait one moment. Today evening about 22.00 GMT I will send you my proposal of changes in the 'basic-options.xul' and 'advanced-options.xul' files. About "text-link" style I was wrote on BabelZilla.
Haven't any problem with iframe. It was Muro's mistake.
Title: Re: Localization
Post by: m4j3s4 on July 11, 2007, 09:53:35 PM
Eric, those changes proposed by Teo doesn't have anything to do with "tips.xul", does it?

Should I keep on removing the bolds and links?
Title: Re: Localization
Post by: Eric H. Jung on July 11, 2007, 10:15:43 PM
Eric, those changes proposed by Teo doesn't have anything to do with "tips.xul", does it?
No, this has nothing to do with localization and tips.xul. Teo just like to work on GUI stuff.

Quote
Should I keep on removing the bolds and links?
Yes, please.

Topic split and moved here (http://forums.passwordmaker.org/index.php/topic,1351.msg1280208.html#msg1280208)
Title: Re: Localization
Post by: m4j3s4 on July 12, 2007, 04:48:06 AM
I made the changes to the "Tips" window as we last talked.
The window now looks like this:
(http://www.imagehosting.com/out.php/i894199_tela5.jpg)

I removed the bolds, links and line breaks from "passwdmaker.dtd". I also split the entity tips.001.innerHTML into tips.001a.innerHTML and tips.001b.innerHTML in order to keep two lines on top of the window.

This new version runs on SeaMonkey but it doesn't display the localized strings. I must still debug it.

Now, we should upload to BabelZilla the changed "passwdmaker.dtd" and warn the others translators about these changes.

Besides, I added my name to the About Box. Thank you so much!
Title: Re: Localization
Post by: teo951 on July 12, 2007, 10:15:36 PM
I see you preferred html, me xul :). Please tell me for what are two buttons 'OK' and 'Cancel' What 'OK' button working?
Title: Re: Localization
Post by: Goofy on July 12, 2007, 11:54:18 PM
 :D I suppose teo means one "Close" button would be enough ;)
Title: Re: Localization
Post by: m4j3s4 on July 13, 2007, 02:00:50 AM
The previous screen is about localization only. The "OK" and "Cancel" buttons already existed in the original. I haven't changed that.

I tried not to change the original code much. I'm just adding localization.

But I think that one button would be better, too.
Title: Re: Localization
Post by: m4j3s4 on July 13, 2007, 03:35:16 AM
Eric, yesterday I made the following changes to "passwdmaker.dtd":
- split of tips.001.innerHTML into tips.001a.innerHTML and tips.001b.innerHTML;
- removal of bolds, links and line breaks from tips.002.innerHTML, tips.007.innerHTML and tips.008.innerHTML.

I think we should now send them to BabelZilla and warn the translators about them.

How can we do that?

Title: Re: Localization
Post by: Eric H. Jung on July 13, 2007, 01:42:34 PM
Eric, yesterday I made the following changes to "passwdmaker.dtd":
- split of tips.001.innerHTML into tips.001a.innerHTML and tips.001b.innerHTML;
- removal of bolds, links and line breaks from tips.002.innerHTML, tips.007.innerHTML and tips.008.innerHTML.

I think we should now send them to BabelZilla and warn the translators about them.

How can we do that?

Yes, I will do that tonight as well as make just one button on the dialog.
Title: Re: Localization
Post by: Goofy on July 15, 2007, 05:25:59 PM
In case it may interest other localizations addicts ;), this is a version including a tips.xul with all special characters that need no translation, instead of having them in the dtd.

Changes are to be seen here
http://pastebin.mozilla.org/139941

xpi to be grabbed here
http://www.sendspace.com/file/l9d46v (http://www.sendspace.com/file/l9d46v)
Title: Re: Localization
Post by: m4j3s4 on August 19, 2007, 02:51:01 AM
The current English version of "passwdmaker.dtd" file on SourceForge is not the same as the one on BabelZilla.
These entities are missing in the BabelZilla English version:
- options.005.label, options.005.accesskey, options.005.tooltip
- advanced-options.034a.value, advanced-options.034a.accesskey, advanced-options.034a.tooltiptext

Therefore, those entities are also missing in the other languages, which causes errors with current SourceForge version of "options.xul".

Eric, could you please upload the current version of "passwdmaker.dtd" file to BabelZilla? Thank you in advance.
Title: Re: Localization
Post by: Eric H. Jung on August 21, 2007, 03:14:37 AM
Eric, could you please upload the current version of "passwdmaker.dtd" file to BabelZilla? Thank you in advance.

Hi Mauro, I'm not ignoring you. I'm adding some more code with new strings that need translation. Rather than upload the version right now to Babelzilla, I'd like to wait until I'm complete (this week) and upload it then. That way, translators will only have to translate one XPI. Hope you understand? If you'd like me to email the XPI to you directly, let me know... I can do that.

Eric
Title: Re: Localization
Post by: m4j3s4 on August 22, 2007, 12:19:47 AM
Eric, could you please upload the current version of "passwdmaker.dtd" file to BabelZilla? Thank you in advance.

Hi Mauro, I'm not ignoring you. I'm adding some more code with new strings that need translation. Rather than upload the version right now to Babelzilla, I'd like to wait until I'm complete (this week) and upload it then. That way, translators will only have to translate one XPI. Hope you understand? If you'd like me to email the XPI to you directly, let me know... I can do that.

Eric

No problem. I thought I'd better warn you about those missing entities in case you hadn't noticed. No need to send me the XPI. Thank you, anyway.
Title: Re: Localization
Post by: Eric H. Jung on August 26, 2007, 02:46:37 AM
New version -- 1.7b4 -- uploaded to Babelzilla. This should be the last beta release for 1.7!!