PasswordMaker Forums

Firefox/SeaMonkey/Mozilla/Netscape/Flock Browser Extension => Bugs => Topic started by: f on September 22, 2005, 07:46:36 AM

Title: Wrong generated passwords 0.8.5
Post by: f on September 22, 2005, 07:46:36 AM
Password generation bug introduced in version 0.8.2 bug persists in version 0.8.5
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on September 22, 2005, 11:46:30 AM
Hi,

Can you be more specific? Which bug? There were 2 or 3 that Eric was working on and I believe he believes he got them all. How can we reproduce the bug?

Thanks for your feedback...
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on September 22, 2005, 12:33:10 PM
Yes, need more info... which hash, for instance?
Title: Wrong generated passwords 0.8.5
Post by: f on September 26, 2005, 12:15:04 PM
* Right click on password field -> Populate with PasswordMaker fails to generate the correct password

* Tools->PasswordMaker generates the correct password and "Copy generated password to clipboard" also generates the correct password.

* Using default settings (MD5, no leet) and 8 character password length

* Same problem with versions 0.8.3 to 0.8.6, running Windows XP SP2 and Windows 2000 SP4 (firefox 1.0.6 es-ES)

* Sample domains: GMail, Yahoo mail... but it fails with ALL domains I tried.

Thank you
Title: Wrong generated passwords 0.8.5
Post by: Tyrantmizar on September 26, 2005, 09:32:55 PM
Have you made sure that your URL to match is not gmail.google.com (or mail.google.com)?  For security, google redirects you to https://www.google.com/ (https://www.google.com/)...  

mail.yahoo.com sometimes goes to login.yahoo.com
Title: Wrong generated passwords 0.8.5
Post by: f on September 27, 2005, 02:52:45 PM
Sure, domain only (google.com and yahoo.com)
Title: Wrong generated passwords 0.8.5
Post by: f on September 27, 2005, 03:00:23 PM
Well, 0.8.7 fails too

Sample URL:

http://edit.europe.yahoo.com/config/login?...mail.yahoo.com/ (http://edit.europe.yahoo.com/config/login?.intl=es&.partner=&.src=ym&.done=http%3a//mail.yahoo.com/)

PasswordMaker uses yahoo.com as URL. 0.8.2 runs fine, 0.8.3 to 0.8.7 fail
Title: Wrong generated passwords 0.8.5
Post by: Rick Bull on October 03, 2005, 10:36:49 PM
Hi, I get this same error too, which I found was introduced a few versions back (probably version 0.8.2, as f stated). A couple of sites I find this occurs on are:I have the following settings:I get the same thing as f: fine if I use the "copy password to clipboard" function, but not with "populate...". For me this is quite a serious problem, and I'm thinking of going back to using my normal password, but I'd prefer not to, and am prepared to help more if you need it.
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 03, 2005, 11:52:09 PM
I haven't been able to reproduce this on my end... and I just created a new account at Planet-Save and entered one password using the right-click > populate, and the other with the 'Copy to Clipboard'.

One thing I did remember when doing this that you may not have noticed...

When you use the 'Copy to Clipboard', you have to open the PM Settings...

What you may be missing is, there is already a password generated, and you *can* copy it to the clipboard - WITHOUT ENTERING YOUR MASTER PASSWORD - but if you do this, the password will be different than the one that gets populated from the right-click, because it prompts you for your Master Password. I actually ran into this myself when I first tried to use PM...

If this isn't the problem, have you guys tried testing with a clean profile and fresh install of the PM extension?
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 04, 2005, 06:26:01 AM
I only just saw this revived thread now (from Sep 26 until today). Sorry about that. I will look into it tomorrow and see if I can reproduce it, but if tanstaafl can't, it's likely that I won't be able to, either.

Will repost after I have more info...

-Eric
edit: if anyone else can help me recreate this bug reliably, I would greatly appreciate it. It is quite major.
Title: Wrong generated passwords 0.8.5
Post by: Rick Bull on October 04, 2005, 09:16:44 AM
Quote
When you use the 'Copy to Clipboard', you have to open the PM Settings...

What you may be missing is, there is already a password generated, and you *can* copy it to the clipboard - WITHOUT ENTERING YOUR MASTER PASSWORD - but if you do this, the password will be different than the one that gets populated from the right-click, because it prompts you for your Master Password. I actually ran into this myself when I first tried to use PM...
I definitely re-entered the password in the dialog, so it wasn't that.

Also, I recently changed my password on Planet-Save back to my normal password, and then back to the PasswordMaker-generated one, and it seems to work on the log-in page now. So could it just be that the characters used have changed from the pre-0.8.2 version?
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 04, 2005, 10:44:02 AM
Depends - there was a change from 0.6 > 0.7, and then Eric added some Pre-set character sets you could choose from. I also seem to recall a one-time issue with an extra zero in the default character set in 0.7...

But... this shouldn't really be an issue - your problem is you are getting different results with an account that is using the *same* settings, just invoking PM differently, right?

What version did you recently upgrade from?
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 04, 2005, 11:15:13 AM
Something else I just noticed...

The ALT-` shortcut doesn't seem to work on planet-save.com for some reason... don't know if this is somehow related (don't see how really)...
Title: Wrong generated passwords 0.8.5
Post by: f on October 04, 2005, 08:05:38 PM
Hi!

When I use the right click menu "Populate With PasswordMaker", I'm prompted to enter the master password twice (Do not store master password) and fails. When I use the "Copy to clipboard", first I enter my master password and runs fine.

Settings:

Firefox 1.0.7 es-ES, Windows XP SP2

Use l33t: Not at all
Hash: MD5
Password length: 8
Characters: 0123456789abcdef
URL: domain
No autopopulate, no prefix, no suffix

Alt+` doesn't work. I'm using an spanish keyboard, where the "`" key is next to the "P" key (maybe are you using the keycode instead of the ASCII code?)

Good luck
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 04, 2005, 08:19:16 PM
Quote
When I use the right click menu "Populate With PasswordMaker", I'm prompted to enter the master password twice (Do not store master password) and fails. When I use the "Copy to clipboard", first I enter my master password and runs fine.
Just to be clear - when you say are *prompted* to enter your Master PAssword twice - do you mean there are two boxes on the Master Password prompt window and you have to enter it twice? Or do you actually get two, separate Master Password pop-up prompts?

Quote
Alt+` doesn't work.
I know - but my point was, it *should* work... Eric?

Quote
I'm using an spanish keyboard, where the "`" key is next to the "P" key (maybe are you using the keycode instead of the ASCII code?)
Nope, just using regular US standard keyboard with the "'" key in the upper left corner (beneath the Esc key).

Weird...
Title: Wrong generated passwords 0.8.5
Post by: Guest on October 04, 2005, 08:33:52 PM
It works!!!!

I tried a fresh install as suggested:

1. Uninstall PasswordMaker (0.8.2 in my case)
2. Manually edit the profile file prefs.js and remove ALL *.passwordmaker.* lines.
3. Install PasswordMaker 0.8.7 xpi
4. Edit PasswordMaker settings to match your old settings (Ctrl+` fails too, use the menu Tools->PasswordMaker)
5. It WORKS!!!

Strange bug, guys. If you simply upgrade or unistall/reinstall without editing the profile, it fails.

Alt+` issue:

I noticed that if you press Alt+` TWICE in the password field (yahoo mail), then the PasswordMaker dialog finally pops. One pressing has no effect.

Thank you very much!!! PasswordMaker is a great extension!!!
Title: Wrong generated passwords 0.8.5
Post by: Guest on October 04, 2005, 08:36:34 PM
When I say "prompted twice" I mean password confirmation, not two popups.
Title: Wrong generated passwords 0.8.5
Post by: f on October 04, 2005, 08:37:27 PM
Sorry, I forgot to enter my name in the 2 previous posts
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 04, 2005, 11:28:30 PM
Quote
The ALT-` shortcut doesn't seem to work on planet-save.com for some reason... don't know if this is somehow related (don't see how really)...
This site has their login page in a frame. ALT-` used to work with frames, but it appears that I removed that code. I'll put it back in.

Quote
I noticed that if you press Alt+` TWICE in the password field (yahoo mail), then the PasswordMaker dialog finally pops. One pressing has no effect.
I can't reproduce this. Do you mean Ctrl-`?

Are those the only issues here, or am I missing one?
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 05, 2005, 01:12:27 AM
Quote
This site has their login page in a frame. ALT-` used to work with frames, but it appears that I removed that code. I'll put it back in.
Ahh... ok, that explains it... hopefully there wasn't a good reason you removed it in the first place...

Quote
Quote
I noticed that if you press Alt+` TWICE in the password field (yahoo mail), then the PasswordMaker dialog finally pops. One pressing has no effect.
I can't reproduce this. Do you mean Ctrl-`?
I'm not sure what f is talking about here... the planet-save.com site is the first time I've encountered one where ALT-` didn't work - Yahoo has always worked for me, and still does... but the PM window opens right up for me, so not sure where this other problem is coming from...

Quote
. Edit PasswordMaker settings to match your old settings (Ctrl+` fails too,
f - above you said Ctrl, but later you said Alt... are you sure we're talking about the same keys? You had asked me whether I was using the 'keycode' instead of the 'ascii' code - but I'm not sure I understand why you're asking me that - I am simply hitting the key combination (the ALT key and the ' key (ascii code 96)) on my keyboard. By the way, just to be sure - the ' key is ascii code 96, NOT code 39 - and that is the key I'm pressing.

Hmmm... I just thought of and tried one last thing, and was actually able to reproduce (once) what you described (having to hit the keys twice in succession before the dialog came up)... you're not by any chance hitting THREE keys are you? When I tried hitting the [ALT], the [-], and the [`] keys all three at the same time, I noticed what you described, but it wasn't consistent...

Last dumb question, but maybe the ALT key you are using is bad? Did you try the other one?

Also - do you remember what version of PM you staretd with (the first version you installed)?

Quote
Strange bug, guys. If you simply upgrade or unistall/reinstall without editing the profile, it fails.
I'm not convinced this is a bug... I have been using PM since 0.51, and I have never had to edit anything in my profile - although, that said, out of habit, I *always* uninstall something before installing a new version - it just seems cleaner to me - so, I guess it is possible it is a bug related to installing a new version on top of an older one...

Eric? At least we know the version he started having problems with (0.82). Maybe tomorrow I can play with this and see if I can reproduce it - if I do, I'll post the steps for you...

Anyway, f, as for the ALT-` problem, it sounds to me like you may either have a bad key, or maybe another extension that is conflicting... any chance you could post your list of installed extensions?

Otherwise, I'm out of ideas. The only reason I'm trying so hard on this is I don't like the idea of a bug in this, my favorite and oh-so-critical program...  :police:
Title: Wrong generated passwords 0.8.5
Post by: f on October 05, 2005, 07:10:30 AM
Hi,

Alt-` to populate password field: I tried in another PC (W2K SP4) with another keyboard and it must be pressed TWICE again to pop-up the password dialog to enter my master password. So my Alt key is OK. It happens in every domain I tried.

Ctrl+` to open the options dialog: it doesn't work. It only opens through the "Tools->PasswordMaker" menu.

It seems there's a problem with non US keyboards and the ` key.

Installed extensions:

PasswordMaker 0.8.7 ;)
vbrowseit 1.0
Tabbrowser Preferences 1.2.7.1
IE View 1.2.5
Resize Search Box 0.0.5
Adblock
Flashblock 1.2.9
Disable Targets For Downloads 1.0

I think I started to use PasswordMaker since version 0.7

Hope it helps.
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 05, 2005, 12:20:26 PM
Quote
It seems there's a problem with non US keyboards and the ` key.
For some reason I blocked this part...

Yes, this makes sense. Guess we'll have to wait until Eric can take a look. Could be a source of other problems too, so I'm sure he'll look closely at it...

Thanks for being so patient, and willing to work through this problem with us... it will only make PASSWORDMAKER better in the end.

Lastly, just for clarity sake, this thread is discussing two different issues:

1) There is apparently some set of circumstances stemming from upgrading PASSWORDMAKER from versions older than 0.82 that can result in different passwords being generated by the right-click/populate and 'Copy to Clipboard' methods.

If you run into this problem, the fix is to:2) There is also apparently a problem with the Spanish, and possibly other non-us keyboard layouts, and the use of the ALT-` and CTRL-` key combinations (most likely the problem is just with the ` key), though this has not been confirmed. Until it has, if you are using a non-us keyboard layout, it would be appreciated if you would report whether or not you are having any problems in the new thread (http://forums.passwordmaker.org/index.php?showtopic=432) created to track this issue.
Title: Wrong generated passwords 0.8.5
Post by: Rick Bull on October 05, 2005, 01:10:01 PM
I think following f's advice has cured the problem for me too. I'm having trouble logging in to some sites now, but I think that's because I changed my password to the erroneous one that PasswordMaker geneated, so I'll have to figure that out myself!

PasswordMaker seems to be generating the same passwords whichever way I do it now, so I think it must just have been some bad prefs. I thought after I edited my prefs.js file, that I should have made a note of them first, in case it helped you guys to figure out what the problem was. Too late now though; sorry!
Title: Wrong generated passwords 0.8.5
Post by: tanstaafl on October 05, 2005, 02:06:39 PM
Hi Rick,

Ok, great to hear that the suggested fix worked for you too.

Now, I'm gonna spend some time to try to nail down when/where it happens so Eric can determine the source of the problem and provide a fix.
Title: Wrong generated passwords 0.8.5
Post by: f on October 05, 2005, 02:27:34 PM
Quote
Thanks for being so patient, and willing to work through this problem with us... it will only make PASSWORDMAKER better in the end.
 
You're welcome!
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 05, 2005, 05:59:31 PM
F,
Would you be willing to install the KeyConfig (http://extensionroom.mozdev.org/more-info/keyconfig) extension and map Ctrl-` and Alt-` to different keys on your Spanish keyboard? I don't have access to Spanish Windows and a Spanish keyboard else I'd do it myself. I'd like to know if the shortcuts work for you (only pressing them ONCE) after re-mapping with KeyConfig.

Thank you,
Eric
Title: Wrong generated passwords 0.8.5
Post by: f on October 05, 2005, 08:11:32 PM
Sure!

I tried and it works perfectly:

Alt-`changed to Alt-9
Ctrl+`changed to Ctrl+9

(9 in the numbers row, not in the numeric keypad)

I found an interesting thing:

In the spanish keyboard, the "`" key is shared with "^" (shift) and "[" (AltGr). When I tried to configure back to Ctrl+`, keyconfig displays Ctrl+[ instead of Ctrl+`, but this mapping works!!! It seems that Ctrl+` maps to Ctrl+[ in the spanish layout.

On the other way, Alt-` displays Alt-`, but again, it must be pressed twice and it displays TWO password prompts: one normal sized and another "maximized".

Hope it helps.
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 05, 2005, 08:31:14 PM
Quote
In the spanish keyboard, the "`" key is shared with "^" (shift) and "[" (AltGr).
Strange - no keys on full-sized, standard US-English keyboards share 3 characters. The only exception to this which I know about are smaller-sized notebook/laptop keyboards where there is a "function" key. Keys which use the function key often have 3 meanings or characters.

Quote
On the other way, Alt-` displays Alt-`, but again, it must be pressed twice and it displays TWO password prompts: one normal sized and another "maximized".
Can you show a screen picture of this? You can host images at image shack (http://imageshack.us) for free since these forums don't support images directly.
Title: Wrong generated passwords 0.8.5
Post by: f on October 06, 2005, 01:19:41 PM
Done!

Not sure if it was uploaded correctly, because web page hung. Filename is "AltTwice.png"

I can send it by email if not correctly posted.
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 06, 2005, 01:22:20 PM
Hi,

Quote
Filename is "AltTwice.png"
I need a URL to view it. After you upload the image, imageshack shows you the URL to access it. If their web page hung, you didn't get to see this... :(

Can you try again... or send by PM or email, that's fine.
Title: Wrong generated passwords 0.8.5
Post by: f on October 06, 2005, 05:24:41 PM
I got it:

http://img188.imageshack.us/img188/9105/alttwice2fu.png (http://img188.imageshack.us/img188/9105/alttwice2fu.png)
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 06, 2005, 06:53:24 PM
Weird!
Title: Wrong generated passwords 0.8.5
Post by: Guest on October 16, 2005, 04:33:50 PM
I have this problem too. I hate having to uninstall something before reinstalling. I will do it *just this once* :P
Title: Wrong generated passwords 0.8.5
Post by: Eric H. Jung on October 16, 2005, 04:48:05 PM
Did you open more than one tab simultaneously? Like a folder of bookmarks?