PasswordMaker Forums

Firefox/SeaMonkey/Mozilla/Netscape/Flock Browser Extension => Bugs => Topic started by: Bugman on March 15, 2009, 08:15:39 AM

Title: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Bugman on March 15, 2009, 08:15:39 AM

First of all, I think this extension is great.

Shortly after using this extension in Firefox 3.0.7/Vista, I noticed the following:

1) Go to any web page.
2) Right click on a blank area, choose "Bookmark This Page"
3) To the far right of the "Folder" area, click on the square with down arrow. It has the tooltip that says "Show all the bookmarks folders"
4) You'll notice all the folders here appear in BOLD, but they are not supposed to. If you repeat these steps with Firefox in safe-mode, you'll see they don't appear in bold.

I think I have found what is causing the bug. I looked through the source files for this extension, searching for "bold"
The bug is in passwdmaker.css, line 46
I changed line 46 to "font-weight: normal;" and the problem seems to be fixed.

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Eric H. Jung on May 03, 2009, 03:50:12 PM

I'm wondering why I never got email notification about this post so I could have replied in a reasonable time frame.

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: tanstaafl on May 04, 2009, 09:44:59 AM

Same here...

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Eric H. Jung on August 28, 2009, 03:25:53 AM

This fix is now committed and will be in the next release.
http://passwordmaker.svn.sourceforge.net/viewvc/passwordmaker?view=rev&revision=454

Eric

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Bugman on September 13, 2009, 08:38:21 PM

Quote from: Bugman on March 15, 2009, 08:15:39 AM

First of all, I think this extension is great.

Shortly after using this extension in Firefox 3.0.7/Vista, I noticed the following:

1) Go to any web page.
2) Right click on a blank area, choose "Bookmark This Page"
3) To the far right of the "Folder" area, click on the square with down arrow. It has the tooltip that says "Show all the bookmarks folders"
4) You'll notice all the folders here appear in BOLD, but they are not supposed to. If you repeat these steps with Firefox in safe-mode, you'll see they don't appear in bold.

I think I have found what is causing the bug. I looked through the source files for this extension, searching for "bold"
The bug is in passwdmaker.css, line 46
I changed line 46 to "font-weight: normal;" and the problem seems to be fixed.

i just updated to 1.7.3 and this bug is still here

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Miquel 'Fire' Burns on September 13, 2009, 09:15:32 PM

That version was 'released' before the bug was fixed. Big backlog on the addons.mozilla.org site.

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Bugman on September 27, 2009, 03:26:25 PM

Quote from: Miquel 'Fire' Burns on September 13, 2009, 09:15:32 PM

That version was 'released' before the bug was fixed. Big backlog on the addons.mozilla.org site.

what's the fixed version number? 1.7.4? i still haven't gotten the fixed version from mozilla.

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Miquel 'Fire' Burns on September 27, 2009, 08:13:39 PM

Nothing been released yet. It's only in SVN right now. (it will be 1.7.4, unless a new feature bumps it up to 1.8)

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Eric H. Jung on September 28, 2009, 11:59:19 PM

eh, i got a notice that 1.7.4 was approved...a week or two ago.

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Miquel 'Fire' Burns on September 29, 2009, 01:05:51 AM

I think that was 1.7.3 you're thinking of (which you forgot to update the version number in the about dialog)

Title: Re: This extension causes a bookmarks bug (visual) and I know where the problem is
Post by: Eric H. Jung on September 29, 2009, 02:11:24 PM

Quote from: Miquel 'Fire' Burns on September 29, 2009, 01:05:51 AM

I think that was 1.7.3 you're thinking of (which you forgot to update the version number in the about dialog)

ah, true. I'm used to my other extensions which read the version number dynamically for display in the about dialog. Forgot that PasswordMaker doesn't do that!